pgsql: Parse libpq's "keepalives" option more like other integer option
От | Tom Lane |
---|---|
Тема | pgsql: Parse libpq's "keepalives" option more like other integer option |
Дата | |
Msg-id | E1sw6vr-001uOQ-Vr@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Parse libpq's "keepalives" option more like other integer options. Use pqParseIntParam (nee parse_int_param) instead of using strtol directly. This allows trailing whitespace, which the previous coding didn't, and makes the spelling of the error message consistent with other similar cases. This seems to be an oversight in commit e7a221797, which introduced parse_int_param. That fixed places that were using atoi(), but missed this place which was randomly using strtol() instead. Ordinarily I'd consider this minor cleanup not worth back-patching. However, it seems that ecpg assumes it can add trailing whitespace to URL parameters, so that use of the keepalives option fails in that context. Perhaps that's worth improving as a separate matter. In the meantime, back-patch this to all supported branches. Yuto Sasaki (some further cleanup by me) Discussion: https://postgr.es/m/TY2PR01MB36286A7B97B9A15793335D18C1772@TY2PR01MB3628.jpnprd01.prod.outlook.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47d8a15deaebc755daf0289993e5898a3536a107 Modified Files -------------- src/interfaces/libpq/fe-connect.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
В списке pgsql-committers по дате отправления: