pgsql: Replace gratuitous memmove() with memcpy()

Replace gratuitous memmove() with memcpy()

The index access methods all had similar code that copied the
passed-in scan keys to local storage.  They all used memmove() for
that, which is not wrong, but it seems confusing not to use memcpy()
when that would work.  Presumably, this was all once copied from
ancient code and never adjusted.

Discussion: https://www.postgresql.org/message-id/flat/f8c739d9-f48d-4187-b214-df3391ba41ab@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8b5c6a54c4396bb9daeb9ec5d9cbb0d3deedcbe3

Modified Files
--------------
contrib/bloom/blscan.c              | 5 +----
src/backend/access/brin/brin.c      | 3 +--
src/backend/access/gin/ginscan.c    | 5 +----
src/backend/access/gist/gistscan.c  | 6 ++----
src/backend/access/hash/hash.c      | 6 +-----
src/backend/access/nbtree/nbtree.c  | 4 +---
src/backend/access/spgist/spgscan.c | 6 ++----
7 files changed, 9 insertions(+), 26 deletions(-)