pgsql: Make postgres_fdw's query_cancel test less flaky.
От | Tom Lane |
---|---|
Тема | pgsql: Make postgres_fdw's query_cancel test less flaky. |
Дата | |
Msg-id | E1sk8X3-002Ai0-WC@gemulon.postgresql.org обсуждение исходный текст |
Ответы |
Re: pgsql: Make postgres_fdw's query_cancel test less flaky.
|
Список | pgsql-committers |
Make postgres_fdw's query_cancel test less flaky. This test occasionally shows +WARNING: could not get result of cancel request due to timeout which appears to be because the cancel request is sometimes unluckily sent to the remote session between queries, and then it's ignored. This patch tries to make that less probable in three ways: 1. Use a test query that does not involve remote estimates, so that no EXPLAINs are sent. 2. Make sure that the remote session is ready-to-go (transaction started, SET commands sent) before we start the timer. 3. Increase the statement_timeout to 100ms, to give the local session enough time to plan and issue the query. We might have to go higher than 100ms to make this adequately stable in the buildfarm, but let's see how it goes. Back-patch to v17 where this test was introduced. Jelte Fennema-Nio and Tom Lane Discussion: https://postgr.es/m/578934.1725045685@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0e5c823806a3519a3f6966637cb62755dee659d4 Modified Files -------------- contrib/postgres_fdw/expected/query_cancel.out | 26 +++++++++++++++++++------- contrib/postgres_fdw/sql/query_cancel.sql | 18 +++++++++++++----- 2 files changed, 32 insertions(+), 12 deletions(-)
В списке pgsql-committers по дате отправления: