Assign error codes where missing for user-facing failures
All the errors triggered in the code paths patched here would cause the
backend to issue an internal_error errcode, which is a state that should
be used only for "can't happen" situations. However, these code paths
are reachable by the regression tests, and could be seen by users in
valid cases. Some regression tests expect internal errcodes as they
manipulate the backend state to cause corruption (like checksums), or
use elog() because it is more convenient (like injection points), these
have no need to change.
This reduces the number of internal failures triggered in a check-world
by more than half, while providing correct errcodes for these valid
cases.
Reviewed-by: Robert Haas
Discussion: https://postgr.es/m/Zic_GNgos5sMxKoa@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b81a71aa05f294705e1b1d4fe24548f175f9bfe9
Modified Files
--------------
contrib/pg_walinspect/pg_walinspect.c | 3 ++-
src/backend/access/transam/xlogrecovery.c | 3 ++-
src/backend/backup/basebackup.c | 6 ++++--
src/backend/commands/matview.c | 4 +++-
src/backend/commands/tablecmds.c | 3 ++-
src/backend/commands/trigger.c | 1 +
src/backend/commands/user.c | 2 ++
src/backend/libpq/be-secure-openssl.c | 3 ++-
src/backend/optimizer/util/appendinfo.c | 12 ++++++++----
src/backend/replication/slotfuncs.c | 3 ++-
src/backend/utils/adt/pg_locale.c | 21 ++++++++++++++-------
src/backend/utils/adt/tid.c | 24 +++++++++++++++++-------
12 files changed, 59 insertions(+), 26 deletions(-)