pgsql: Fix potential stack overflow in incremental backup.
| От | Thomas Munro |
|---|---|
| Тема | pgsql: Fix potential stack overflow in incremental backup. |
| Дата | |
| Msg-id | E1rujcx-001X28-QA@gemulon.postgresql.org обсуждение |
| Ответы |
Re: pgsql: Fix potential stack overflow in incremental backup.
|
| Список | pgsql-committers |
Fix potential stack overflow in incremental backup. The user can set RELSEG_SIZE to a high number at compile time, so we can't use it to control the size of an array on the stack: it could be many gigabytes in size. On closer inspection, we don't really need that intermediate array anyway. Let's just write directly into the output array, and then perform the absolute->relative adjustment in place. This fixes new code from commit dc212340058. Reviewed-by: Robert Haas <robertmhaas@gmail.com> Discussion: https://postgr.es/m/CA%2BhUKG%2B2hZ0sBztPW4mkLfng0qfkNtAHFUfxOMLizJ0BPmi5%2Bg%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d8f5acbdb9b22106db583e3cbb177d34e6b18eeb Modified Files -------------- src/backend/backup/basebackup_incremental.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-)
В списке pgsql-committers по дате отправления: