pgsql: Fix the way SJE removes references from PHVs

Fix the way SJE removes references from PHVs

Add missing replacement of relids in phv->phexpr.  Also, remove extra
replace_relid() over phv->phrels.

Reported-by:  Zuming Jiang
Bug: #18187
Discussion: https://postgr.es/m/flat/18187-831da249cbd2ff8e%40postgresql.org
Author: Richard Guo
Reviewed-by: Andrei Lepikhov

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b44a1708abe306831073cf88bb0ba6a11e68daee

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c |  4 ++--
src/test/regress/expected/join.out        | 19 +++++++++++++++++++
src/test/regress/sql/join.sql             |  8 ++++++++
3 files changed, 29 insertions(+), 2 deletions(-)