pgsql: Add trailing commas to enum definitions

Add trailing commas to enum definitions

Since C99, there can be a trailing comma after the last value in an
enum definition.  A lot of new code has been introducing this style on
the fly.  Some new patches are now taking an inconsistent approach to
this.  Some add the last comma on the fly if they add a new last
value, some are trying to preserve the existing style in each place,
some are even dropping the last comma if there was one.  We could
nudge this all in a consistent direction if we just add the trailing
commas everywhere once.

I omitted a few places where there was a fixed "last" value that will
always stay last.  I also skipped the header files of libpq and ecpg,
in case people want to use those with older compilers.  There were
also a small number of cases where the enum type wasn't used anywhere
(but the enum values were), which ended up confusing pgindent a bit,
so I left those alone.

Discussion: https://www.postgresql.org/message-id/flat/386f8c45-c8ac-4681-8add-e3b0852c1620%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/611806cd726fc92989ac918eac48fd8d684869c7

Modified Files
--------------
contrib/amcheck/verify_heapam.c                  |  6 +--
contrib/btree_gist/btree_gist.h                  |  2 +-
contrib/pg_prewarm/pg_prewarm.c                  |  2 +-
contrib/pg_stat_statements/pg_stat_statements.c  |  4 +-
contrib/pg_surgery/heap_surgery.c                |  2 +-
contrib/pgcrypto/pgp.h                           | 12 ++---
contrib/postgres_fdw/deparse.c                   |  2 +-
contrib/postgres_fdw/postgres_fdw.c              |  8 +--
contrib/postgres_fdw/postgres_fdw.h              |  2 +-
contrib/vacuumlo/vacuumlo.c                      |  2 +-
src/backend/access/gist/gistbuild.c              |  2 +-
src/backend/access/heap/vacuumlazy.c             |  2 +-
src/backend/access/nbtree/nbtree.c               |  2 +-
src/backend/access/nbtree/nbtsplitloc.c          |  2 +-
src/backend/access/spgist/spgscan.c              |  2 +-
src/backend/access/transam/slru.c                |  2 +-
src/backend/access/transam/xact.c                |  4 +-
src/backend/access/transam/xlogprefetcher.c      |  2 +-
src/backend/access/transam/xlogrecovery.c        |  2 +-
src/backend/catalog/pg_shdepend.c                |  2 +-
src/backend/commands/async.c                     |  2 +-
src/backend/commands/copyto.c                    |  2 +-
src/backend/commands/dbcommands.c                |  2 +-
src/backend/commands/user.c                      |  2 +-
src/backend/commands/vacuumparallel.c            |  2 +-
src/backend/executor/execIndexing.c              |  2 +-
src/backend/executor/functions.c                 |  2 +-
src/backend/executor/nodeMergejoin.c             |  2 +-
src/backend/executor/nodeTidrangescan.c          |  2 +-
src/backend/libpq/auth-scram.c                   |  2 +-
src/backend/nodes/tidbitmap.c                    |  4 +-
src/backend/optimizer/path/allpaths.c            |  2 +-
src/backend/optimizer/path/indxpath.c            |  2 +-
src/backend/optimizer/plan/setrefs.c             |  2 +-
src/backend/optimizer/util/pathnode.c            |  2 +-
src/backend/optimizer/util/predtest.c            |  2 +-
src/backend/parser/parse_collate.c               |  2 +-
src/backend/parser/parse_cte.c                   |  2 +-
src/backend/parser/parse_func.c                  |  2 +-
src/backend/partitioning/partprune.c             |  4 +-
src/backend/port/sysv_shmem.c                    |  2 +-
src/backend/postmaster/autovacuum.c              |  2 +-
src/backend/postmaster/postmaster.c              |  4 +-
src/backend/regex/regc_pg_locale.c               |  2 +-
src/backend/replication/logical/worker.c         |  2 +-
src/backend/replication/pgoutput/pgoutput.c      |  2 +-
src/backend/replication/walreceiver.c            |  2 +-
src/backend/storage/file/fd.c                    |  2 +-
src/backend/storage/ipc/procarray.c              |  4 +-
src/backend/utils/adt/arrayfuncs.c               |  2 +-
src/backend/utils/adt/formatting.c               |  2 +-
src/backend/utils/adt/jsonb_gin.c                |  2 +-
src/backend/utils/adt/jsonfuncs.c                |  2 +-
src/backend/utils/adt/like_support.c             |  4 +-
src/backend/utils/adt/rangetypes_gist.c          |  2 +-
src/backend/utils/adt/tsquery.c                  |  4 +-
src/backend/utils/cache/evtcache.c               |  2 +-
src/backend/utils/sort/tuplesort.c               |  2 +-
src/backend/utils/sort/tuplestore.c              |  2 +-
src/bin/pg_basebackup/bbstreamer.h               |  2 +-
src/bin/pg_basebackup/pg_basebackup.c            |  4 +-
src/bin/pg_basebackup/walmethods.h               |  2 +-
src/bin/pg_checksums/pg_checksums.c              |  2 +-
src/bin/pg_ctl/pg_ctl.c                          |  6 +--
src/bin/pg_dump/parallel.c                       |  2 +-
src/bin/pg_dump/parallel.h                       |  2 +-
src/bin/pg_dump/pg_backup.h                      |  8 +--
src/bin/pg_dump/pg_backup_archiver.h             | 10 ++--
src/bin/pg_dump/pg_dump.c                        |  2 +-
src/bin/pg_dump/pg_dump.h                        |  2 +-
src/bin/pg_rewind/filemap.h                      |  4 +-
src/bin/pg_upgrade/pg_upgrade.h                  |  4 +-
src/bin/pg_verifybackup/parse_manifest.c         |  6 +--
src/bin/pgbench/pgbench.c                        | 10 ++--
src/bin/pgbench/pgbench.h                        |  6 +--
src/bin/psql/command.c                           |  2 +-
src/bin/psql/command.h                           |  2 +-
src/bin/psql/psqlscanslash.h                     |  2 +-
src/bin/psql/settings.h                          | 12 ++---
src/bin/psql/startup.c                           |  2 +-
src/bin/scripts/reindexdb.c                      |  2 +-
src/bin/scripts/vacuumdb.c                       |  2 +-
src/common/cryptohash.c                          |  2 +-
src/common/cryptohash_openssl.c                  |  2 +-
src/common/hmac.c                                |  2 +-
src/common/hmac_openssl.c                        |  2 +-
src/common/jsonapi.c                             |  2 +-
src/include/access/amapi.h                       |  2 +-
src/include/access/genam.h                       |  2 +-
src/include/access/gin_private.h                 |  2 +-
src/include/access/gist_private.h                |  2 +-
src/include/access/heapam.h                      |  2 +-
src/include/access/multixact.h                   |  2 +-
src/include/access/reloptions.h                  |  2 +-
src/include/access/slru.h                        |  2 +-
src/include/access/spgist.h                      |  2 +-
src/include/access/tableam.h                     |  8 +--
src/include/access/toast_compression.h           |  2 +-
src/include/access/xact.h                        |  8 +--
src/include/access/xlog.h                        | 10 ++--
src/include/access/xlog_internal.h               |  2 +-
src/include/access/xlogprefetcher.h              |  2 +-
src/include/access/xlogreader.h                  |  2 +-
src/include/access/xlogrecovery.h                |  6 +--
src/include/access/xlogutils.h                   |  4 +-
src/include/backup/backup_manifest.h             |  2 +-
src/include/catalog/dependency.h                 |  6 +--
src/include/catalog/index.h                      |  2 +-
src/include/catalog/namespace.h                  |  6 +--
src/include/catalog/objectaccess.h               |  2 +-
src/include/catalog/pg_cast.h                    |  8 +--
src/include/catalog/pg_constraint.h              |  2 +-
src/include/catalog/pg_control.h                 |  2 +-
src/include/catalog/pg_init_privs.h              |  4 +-
src/include/commands/copyfrom_internal.h         |  6 +--
src/include/commands/explain.h                   |  2 +-
src/include/common/checksum_helper.h             |  2 +-
src/include/common/compression.h                 |  2 +-
src/include/common/cryptohash.h                  |  2 +-
src/include/common/file_utils.h                  |  4 +-
src/include/common/jsonapi.h                     |  4 +-
src/include/common/relpath.h                     |  2 +-
src/include/common/saslprep.h                    |  2 +-
src/include/executor/hashjoin.h                  |  2 +-
src/include/fe_utils/conditional.h               |  2 +-
src/include/fe_utils/print.h                     |  8 +--
src/include/fe_utils/psqlscan.h                  |  6 +--
src/include/fmgr.h                               |  2 +-
src/include/funcapi.h                            |  2 +-
src/include/libpq/crypt.h                        |  2 +-
src/include/libpq/hba.h                          |  8 +--
src/include/libpq/libpq-be.h                     |  2 +-
src/include/miscadmin.h                          |  2 +-
src/include/nodes/bitmapset.h                    |  4 +-
src/include/nodes/execnodes.h                    | 12 ++---
src/include/nodes/lockoptions.h                  |  6 +--
src/include/nodes/nodes.h                        | 14 ++---
src/include/nodes/parsenodes.h                   | 66 ++++++++++++------------
src/include/nodes/pathnodes.h                    | 10 ++--
src/include/nodes/plannodes.h                    |  8 +--
src/include/nodes/primnodes.h                    | 24 ++++-----
src/include/nodes/queryjumble.h                  |  2 +-
src/include/nodes/replnodes.h                    |  2 +-
src/include/optimizer/cost.h                     |  2 +-
src/include/optimizer/optimizer.h                |  2 +-
src/include/optimizer/paths.h                    |  2 +-
src/include/parser/parse_coerce.h                |  2 +-
src/include/parser/parse_func.h                  |  2 +-
src/include/parser/parser.h                      |  4 +-
src/include/pgstat.h                             |  4 +-
src/include/pgtar.h                              |  6 +--
src/include/postmaster/autovacuum.h              |  2 +-
src/include/postmaster/bgworker.h                |  4 +-
src/include/replication/logicalproto.h           |  2 +-
src/include/replication/output_plugin.h          |  2 +-
src/include/replication/reorderbuffer.h          |  4 +-
src/include/replication/slot.h                   |  2 +-
src/include/replication/snapbuild.h              |  2 +-
src/include/replication/walreceiver.h            |  4 +-
src/include/replication/walsender.h              |  2 +-
src/include/replication/walsender_private.h      |  2 +-
src/include/replication/worker_internal.h        |  6 +--
src/include/rewrite/rewriteManip.h               |  2 +-
src/include/storage/bufmgr.h                     |  4 +-
src/include/storage/dsm_impl.h                   |  2 +-
src/include/storage/lmgr.h                       |  2 +-
src/include/storage/lock.h                       |  6 +--
src/include/storage/lwlock.h                     |  4 +-
src/include/storage/pg_shmem.h                   |  4 +-
src/include/storage/pmsignal.h                   |  2 +-
src/include/storage/predicate_internals.h        |  4 +-
src/include/storage/procsignal.h                 |  2 +-
src/include/storage/shm_mq.h                     |  2 +-
src/include/storage/sync.h                       |  4 +-
src/include/tcop/deparse_utility.h               |  2 +-
src/include/tcop/dest.h                          |  2 +-
src/include/tcop/tcopprot.h                      |  2 +-
src/include/tcop/utility.h                       |  2 +-
src/include/tsearch/dicts/spell.h                |  2 +-
src/include/tsearch/ts_utils.h                   |  2 +-
src/include/utils/acl.h                          |  4 +-
src/include/utils/backend_progress.h             |  2 +-
src/include/utils/backend_status.h               |  2 +-
src/include/utils/bytea.h                        |  2 +-
src/include/utils/elog.h                         |  2 +-
src/include/utils/guc.h                          |  6 +--
src/include/utils/guc_tables.h                   |  6 +--
src/include/utils/hsearch.h                      |  2 +-
src/include/utils/jsonb.h                        |  4 +-
src/include/utils/lsyscache.h                    |  2 +-
src/include/utils/memutils_internal.h            |  2 +-
src/include/utils/plancache.h                    |  2 +-
src/include/utils/portal.h                       |  4 +-
src/include/utils/queryenvironment.h             |  2 +-
src/include/utils/rel.h                          |  4 +-
src/include/utils/relcache.h                     |  2 +-
src/include/utils/resowner.h                     |  2 +-
src/include/utils/rls.h                          |  2 +-
src/include/utils/snapshot.h                     |  2 +-
src/include/utils/syscache.h                     |  2 +-
src/include/utils/timeout.h                      |  2 +-
src/include/utils/tuplesort.h                    |  4 +-
src/include/utils/wait_event.h                   |  2 +-
src/include/utils/xml.h                          |  6 +--
src/interfaces/libpq/fe-auth-scram.c             |  2 +-
src/pl/plpgsql/src/plpgsql.h                     | 24 ++++-----
src/port/path.c                                  |  2 +-
src/test/isolation/isolationtester.h             |  2 +-
src/test/modules/dummy_index_am/dummy_index_am.c |  2 +-
src/test/modules/libpq_pipeline/libpq_pipeline.c |  2 +-
src/test/regress/pg_regress.c                    |  2 +-
src/timezone/localtime.c                         |  2 +-
212 files changed, 390 insertions(+), 390 deletions(-)