pgsql: Fix min_dynamic_shared_memory on Windows.

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема pgsql: Fix min_dynamic_shared_memory on Windows.
Дата
Msg-id E1quJUg-001ik9-9y@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix min_dynamic_shared_memory on Windows.

When min_dynamic_shared_memory is set above 0, we try to find space in a
pre-allocated region of the main shared memory area instead of calling
dsm_impl_XXX() routines to allocate more.  The dsm_pin_segment() and
dsm_unpin_segment() routines had a bug: they called dsm_impl_XXX()
routines even for main region segments.  Nobody noticed before now
because those routines do nothing on Unix, but on Windows they'd fail
while attempting to duplicate an invalid Windows HANDLE.  Add the
missing gating.

Back-patch to 14, where commit 84b1c63a added this feature.  Fixes
pgsql-bugs bug #18165.

Reported-by: Maxime Boyer <maxime.boyer@cra-arc.gc.ca>
Tested-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/18165-bf4f525cea6e51de%40postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dab889d60bac3fbf691973ca1770f2eb50547999

Modified Files
--------------
src/backend/storage/ipc/dsm.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Allow ALTER SYSTEM to set unrecognized custom GUCs.
Следующее
От: Thomas Munro
Дата:
Сообщение: pgsql: Fix min_dynamic_shared_memory on Windows.