pgsql: Fix briefly showing old progress stats for ANALYZE on inherited

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема pgsql: Fix briefly showing old progress stats for ANALYZE on inherited
Дата
Msg-id E1qmamh-006oP7-QW@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix briefly showing old progress stats for ANALYZE on inherited tables.

ANALYZE on a table with inheritance children analyzes all the child
tables in a loop. When stepping to next child table, it updated the
child rel ID value in the command progress stats, but did not reset
the 'sample_blks_total' and 'sample_blks_scanned' counters.
acquire_sample_rows() updates 'sample_blks_total' as soon as the scan
starts and 'sample_blks_scanned' after processing the first block, but
until then, pg_stat_progress_analyze would display a bogus combination
of the new child table relid with old counter values from the
previously processed child table. Fix by resetting 'sample_blks_total'
and 'sample_blks_scanned' to zero at the same time that
'current_child_table_relid' is updated.

Backpatch to v13, where pg_stat_progress_analyze view was introduced.

Reported-by: Justin Pryzby
Discussion: https://www.postgresql.org/message-id/20230122162345.GP13860%40telsasoft.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2d4f99bc693aef5387834333eef06776777f4783

Modified Files
--------------
src/backend/commands/analyze.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Dean Rasheed
Дата:
Сообщение: pgsql: Fix EvalPlanQual rechecking during MERGE.
Следующее
От: Andrew Dunstan
Дата:
Сообщение: pgsql: Provide FORCE_NULL * and FORCE_NOT_NULL * options for COPY FROM