Disallow replacing joins with scans in problematic cases.
Commit e7cb7ee14, which introduced the infrastructure for FDWs and
custom scan providers to replace joins with scans, failed to add support
handling of pseudoconstant quals assigned to replaced joins in
createplan.c, leading to an incorrect plan without a gating Result node
when postgres_fdw replaced a join with such a qual.
To fix, we could add the support by 1) modifying the ForeignPath and
CustomPath structs to store the list of RestrictInfo nodes to apply to
the join, as in JoinPaths, if they represent foreign and custom scans
replacing a join with a scan, and by 2) modifying create_scan_plan() in
createplan.c to use that list in that case, instead of the
baserestrictinfo list, to get pseudoconstant quals assigned to the join;
but #1 would cause an ABI break. So fix by modifying the infrastructure
to just disallow replacing joins with such quals.
Back-patch to all supported branches.
Reported by Nishant Sharma. Patch by me, reviewed by Nishant Sharma and
Richard Guo.
Discussion: https://postgr.es/m/CADrsxdbcN1vejBaf8a%2BQhrZY5PXL-04mCd4GDu6qm6FigDZd6Q%40mail.gmail.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b0e390e6d1d68b92e9983840941f8f6d9e083fe0
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 26 +++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 3 +++
src/backend/optimizer/path/joinpath.c | 19 +++++++++++++++--
src/backend/optimizer/util/restrictinfo.c | 29 ++++++++++++++++++++++++++
src/include/optimizer/restrictinfo.h | 2 ++
5 files changed, 77 insertions(+), 2 deletions(-)