pgsql: Fix setrefs.c code for adjusting partPruneInfos
От | Alvaro Herrera |
---|---|
Тема | pgsql: Fix setrefs.c code for adjusting partPruneInfos |
Дата | |
Msg-id | E1phxc4-000WFa-Sk@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix setrefs.c code for adjusting partPruneInfos We were transferring partPruneInfos from PlannerInfo into PlannerGlobal wrong, essentially relying on all of them being transferred, and adjusting their list indexes based on that. But apparently it's possible that some of them are skipped, so that strategy leads to a corrupted execution tree. Instead, adjust each Append/MergeAppend's partpruneinfo index as we copy from one list to the other, which seems safer anyway. This requires adjusting the RT offset of the RTE referenced in each partPruneInfo ahead of actually adjusting the RTE itself, which seems a bit too ad-hoc. This problem was introduced by commit ec386948948c. However, it may be that we no longer require the change introduced there, so perhaps we should revert both the present commit and that one. Problem noticed by sqlsmith. Author: Amit Langote <amitlangote09@gmail.com Discussion: https://postgr.es/m/CA+HiwqG6tbc2oadsbyyy24b2AL295XHQgyLRWghmA7u_SL1K8A@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/589bb816499e98b60aa5c406c409fb27b42b0e39 Modified Files -------------- src/backend/optimizer/plan/setrefs.c | 83 ++++++++++++++++++++++-------------- 1 file changed, 52 insertions(+), 31 deletions(-)
В списке pgsql-committers по дате отправления: