pgsql: amcheck: Fix FullTransactionIdFromXidAndCtx() for xids before ep
От | Andres Freund |
---|---|
Тема | pgsql: amcheck: Fix FullTransactionIdFromXidAndCtx() for xids before ep |
Дата | |
Msg-id | E1pb87H-0034zt-Q4@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
amcheck: Fix FullTransactionIdFromXidAndCtx() for xids before epoch 0 64bit xids can't represent xids before epoch 0 (see also be504a3e974). When FullTransactionIdFromXidAndCtx() was passed such an xid, it'd create a 64bit xid far into the future. Noticed while adding assertions in the course of investigating be504a3e974, as amcheck's test create such xids. To fix the issue, just return FirstNormalFullTransactionId in this case. A freshly initdb'd cluster already has a newer horizon. The most minimal version of this would make the messages for some detected corruptions differently inaccurate. To make those cases accurate, switch FullTransactionIdFromXidAndCtx() to use the 32bit modulo difference between xid and nextxid to compute the 64bit xid, yielding sensible "in the future" / "in the past" answers. Reviewed-by: Mark Dilger <mark.dilger@enterprisedb.com> Discussion: https://postgr.es/m/20230108002923.cyoser3ttmt63bfn@awork3.anarazel.de Backpatch: 14-, where heapam verification was introduced Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e8a9750d03d70de4ecd5aee37971498d90aabca5 Modified Files -------------- contrib/amcheck/verify_heapam.c | 33 ++++++++++++++++++++++++++----- src/bin/pg_amcheck/t/004_verify_heapam.pl | 28 ++++++++++++++++++-------- 2 files changed, 48 insertions(+), 13 deletions(-)
В списке pgsql-committers по дате отправления: