pgsql: Switch query fixing aclitems in ~15 from O(N^2) to O(N) in upgra

Switch query fixing aclitems in ~15 from O(N^2) to O(N) in upgrade_adapt.sql

f4f2f2b was doing a sequential scan of pg_class before checking if a
relation had attributes dependent on aclitem as data typewhen building
the set of ALTER TABLE queries, but it would be costly on a regression
database.

While on it, make the query style more consistent with the rest.

Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20221223032724.GQ1153@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d3c0cc4447307a2ffbcff8274573b544294e583c

Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 26 +++++++++++---------------
1 file changed, 11 insertions(+), 15 deletions(-)