pgsql: Fix get_dirent_type() for Windows junction points.

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема pgsql: Fix get_dirent_type() for Windows junction points.
Дата
Msg-id E1oEknd-000gRL-1W@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix get_dirent_type() for Windows junction points.

Commit 87e6ed7c8 added code that intended to report Windows "junction
points" as DT_LNK (the same way we report symlinks on Unix).  Windows
junction points are *also* directories according to the Windows
attributes API, and we were reporting them as as DT_DIR.  Change the
order we check the attribute flags, to prioritize DT_LNK.

If at some point we start using Windows' recently added real symlinks
and need to distinguish them from junction points, we may need to
rethink this, but for now this continues the tradition of wrapper
functions that treat junction points as symlinks.

Back-patch to 14, where get_dirent_type() landed.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/CA%2BhUKGLzLK4PUPx0_AwXEWXOYAejU%3D7XpxnYE55Y%2Be7hB2N3FA%40mail.gmail.com
Discussion: https://postgr.es/m/20220721111751.x7hod2xgrd76xr5c%40alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9d3444dcce4d62716edec9c58c1b40be42185e7b

Modified Files
--------------
src/port/dirent.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Fujii Masao
Дата:
Сообщение: pgsql: postgres_fdw: Fix bug in checking of return value of PQsendQuery
Следующее
От: Thomas Munro
Дата:
Сообщение: pgsql: Fix get_dirent_type() for Windows junction points.