Force run of pg_upgrade in the build directory in its TAP test
TAP tests are run from their own directory in the source tree, and in a
VPATH build the execution of the pg_upgrade command was leaving behind a
file in the source tree, that should be left untouched. In order to
avoid this issue, the test moves to PostgreSQL::Test::Utils::tmp_check,
so as any files generated by pg_upgrade do not impact the source tree,
but the build tree. This has as nice side-effect to make unnessary the
presence of such files in pg_upgrade's .gitignore and Makefile. This
strategy is similar to psql's test 010_tab_completion.pl, though the
reasons behind this choice are different.
In passing, fix one misleading test name that was added by 99f6f19.
Per discussion with Peter Eisentraut, Andrew Dunstan, Tom Lane, Andres
Freund and myself.
Discussion: https://postgr.es/m/f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/15b6d2155375dee2fcba072fffa03c1c8b44656c
Modified Files
--------------
src/bin/pg_upgrade/.gitignore | 3 ---
src/bin/pg_upgrade/Makefile | 3 +--
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 7 ++++++-
3 files changed, 7 insertions(+), 6 deletions(-)