pgsql: Remove ppport.h's broken re-implementation of eval_pv().

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Remove ppport.h's broken re-implementation of eval_pv().
Дата
Msg-id E1nHap7-0008WP-V1@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3a6e3a89022f39e0250b23635bcf5985940e6524

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)


В списке pgsql-committers по дате отправления:

Предыдущее
От: noreply@postgresql.org
Дата:
Сообщение: pgsql: Tag refs/tags/REL_12_10 was created
Следующее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR