Fix incautious handling of possibly-miscoded strings in client code.
An incorrectly-encoded multibyte character near the end of a string
could cause various processing loops to run past the string's
terminating NUL, with results ranging from no detectable issue to
a program crash, depending on what happens to be in the following
memory.
This isn't an issue in the server, because we take care to verify
the encoding of strings before doing any interesting processing
on them. However, that lack of care leaked into client-side code
which shouldn't assume that anyone has validated the encoding of
its input.
Although this is certainly a bug worth fixing, the PG security team
elected not to regard it as a security issue, primarily because
any untrusted text should be sanitized by PQescapeLiteral or
the like before being incorporated into a SQL or psql command.
(If an app fails to do so, the same technique can be used to
cause SQL injection, with probably much more dire consequences
than a mere client-program crash.) Those functions were already
made proof against this class of problem, cf CVE-2006-2313.
To fix, invent PQmblenBounded() which is like PQmblen() except it
won't return more than the number of bytes remaining in the string.
In HEAD we can make this a new libpq function, as PQmblen() is.
It seems imprudent to change libpq's API in stable branches though,
so in the back branches define PQmblenBounded as a macro in the files
that need it. (Note that just changing PQmblen's behavior would not
be a good idea; notably, it would completely break the escaping
functions' defense against this exact problem. So we just want a
version for those callers that don't have any better way of handling
this issue.)
Per private report from houjingyi. Back-patch to all supported branches.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/42f94f56bf9559f0a3cf5f3ffde50655834694ee
Modified Files
--------------
src/bin/psql/common.c | 26 +++++++++++++-------------
src/bin/psql/psqlscanslash.l | 2 +-
src/bin/psql/stringutils.c | 6 +++---
src/bin/psql/tab-complete.c | 2 +-
src/bin/scripts/common.c | 2 +-
src/common/jsonapi.c | 6 +++---
src/common/wchar.c | 15 +++++++++++++++
src/fe_utils/print.c | 3 +++
src/fe_utils/string_utils.c | 9 +++------
src/include/mb/pg_wchar.h | 1 +
src/interfaces/libpq/exports.txt | 1 +
src/interfaces/libpq/fe-misc.c | 19 +++++++++++++++++--
src/interfaces/libpq/fe-print.c | 2 +-
src/interfaces/libpq/fe-protocol3.c | 4 ++--
src/interfaces/libpq/libpq-fe.h | 3 +++
15 files changed, 68 insertions(+), 33 deletions(-)