pgsql: Avoid unnecessary table open/close in TRUNCATE command.

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема pgsql: Avoid unnecessary table open/close in TRUNCATE command.
Дата
Msg-id E1lVbfy-0006ph-EY@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Avoid unnecessary table open/close in TRUNCATE command.

ExecuteTruncate() filters out the duplicate tables specified
in the TRUNCATE command, for example in the case where "TRUNCATE foo, foo"
is executed. Such duplicate tables obviously don't need to be opened
and closed because they are skipped. But previously it always opened
the tables before checking whether they were duplicated ones or not,
and then closed them if they were. That is, the duplicated tables were
opened and closed unnecessarily.

This commit changes ExecuteTruncate() so that it opens the table
after it confirms that table is not duplicated one, which leads to
avoid unnecessary table open/close.

Do not back-patch because such unnecessary table open/close is not
a bug though it exists in older versions.

Author: Bharath Rupireddy
Reviewed-by: Amul Sul, Fujii Masao
Discussion: https://postgr.es/m/CALj2ACUdBO_sXJTa08OZ0YT0qk7F_gAmRa9hT4dxRcgPS4nsZA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/81a23dd87999ec9fb62554328c69c5b678612d56

Modified Files
--------------
src/backend/commands/tablecmds.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Fujii Masao
Дата:
Сообщение: pgsql: Remove COMMIT_TS_SETTS record.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix uninitialized variable from commit a4d75c86b.