Add result size as argument of pg_cryptohash_final() for overflow checks
With its current design, a careless use of pg_cryptohash_final() could
would result in an out-of-bound write in memory as the size of the
destination buffer to store the result digest is not known to the
cryptohash internals, without the caller knowing about that. This
commit adds a new argument to pg_cryptohash_final() to allow such sanity
checks, and implements such defenses.
The internals of SCRAM for HMAC could be tightened a bit more, but as
everything is based on SCRAM_KEY_LEN with uses particular to this code
there is no need to complicate its interface more than necessary, and
this comes back to the refactoring of HMAC in core. Except that, this
minimizes the uses of the existing DIGEST_LENGTH variables, relying
instead on sizeof() for the result sizes. In ossp-uuid, this also makes
the code more defensive, as it already relied on dce_uuid_t being at
least the size of a MD5 digest.
This is in philosophy similar to cfc40d3 for base64.c and aef8948 for
hex.c.
Reported-by: Ranier Vilela
Author: Michael Paquier, Ranier Vilela
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/CAEudQAoqEGmcff3J4sTSV-R_16Monuz-UpJFbf_dnVH=APr02Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b83dcf792869fb4a9270d17c961eab75f51c44e4
Modified Files
--------------
contrib/pgcrypto/internal-sha2.c | 2 +-
contrib/pgcrypto/internal.c | 4 ++--
contrib/uuid-ossp/uuid-ossp.c | 5 +++--
src/backend/libpq/auth-scram.c | 2 +-
src/backend/replication/backup_manifest.c | 7 ++++---
src/backend/utils/adt/cryptohashfuncs.c | 3 ++-
src/bin/pg_verifybackup/parse_manifest.c | 3 ++-
src/common/checksum_helper.c | 20 +++++++++++--------
src/common/cryptohash.c | 20 +++++++++++++++----
src/common/cryptohash_openssl.c | 33 ++++++++++++++++++++++++++++++-
src/common/md5_common.c | 4 ++--
src/common/scram-common.c | 8 ++++----
src/include/common/cryptohash.h | 2 +-
13 files changed, 82 insertions(+), 31 deletions(-)