pgsql: Yet more elimination of dead stores and useless initializations.

Yet more elimination of dead stores and useless initializations.

I'm not sure what tool Ranier was using, but the ones I contributed
were found by using a newer version of scan-build than I tried before.

Ranier Vilela and Tom Lane

Discussion: https://postgr.es/m/CAEudQAo1+AcGppxDSg8k+zF4+Kv+eJyqzEDdbpDg58-=MQcerQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a5cc4dab6d1d694f113912a2aca7012a95262f0b

Modified Files
--------------
src/backend/access/common/heaptuple.c |  2 +-
src/backend/access/gist/gistutil.c    |  2 +-
src/backend/access/nbtree/nbtsearch.c |  6 +++---
src/backend/catalog/storage.c         |  3 +--
src/backend/commands/async.c          |  3 +--
src/backend/storage/ipc/procarray.c   |  2 +-
src/backend/tsearch/spell.c           |  2 +-
src/backend/utils/adt/formatting.c    | 19 +++++++++----------
src/backend/utils/adt/tsrank.c        |  4 ++--
src/bin/pg_dump/pg_backup_custom.c    |  7 ++-----
10 files changed, 22 insertions(+), 28 deletions(-)