pgsql: Read until EOF vice stat-reported size in read_binary_file

Поиск
Список
Период
Сортировка
От Joe Conway
Тема pgsql: Read until EOF vice stat-reported size in read_binary_file
Дата
Msg-id E1jrfR0-0000gV-1Y@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Read until EOF vice stat-reported size in read_binary_file

read_binary_file(), used by SQL functions pg_read_file() and friends,
uses stat to determine file length to read, when not passed an explicit
length as an argument. This is problematic, for example, if the file
being read is a virtual file with a stat-reported length of zero.
Arrange to read until EOF, or StringInfo data string lenth limit, is
reached instead.

Original complaint and patch by me, with significant review, corrections,
advice, and code optimizations by Tom Lane. Backpatched to v11. Prior to
that only paths relative to the data and log dirs were allowed for files,
so no "zero length" files were reachable anyway.

Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/flat/969b8d82-5bb2-5fa8-4eb1-f0e685c5d736%40joeconway.com
Backpatch-through: 11

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0025c3a2c295459002711e0b37e48e3b067a83ba

Modified Files
--------------
contrib/adminpack/expected/adminpack.out |  4 +-
src/backend/utils/adt/genfile.c          | 91 ++++++++++++++++++++++----------
2 files changed, 66 insertions(+), 29 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Joe Conway
Дата:
Сообщение: pgsql: Read until EOF vice stat-reported size in read_binary_file
Следующее
От: Joe Conway
Дата:
Сообщение: pgsql: Read until EOF vice stat-reported size in read_binary_file