pgsql: Future-proof regression tests against possibly-missing posixrule

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Future-proof regression tests against possibly-missing posixrule
Дата
Msg-id E1jmLF5-00079e-6W@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Future-proof regression tests against possibly-missing posixrules file.

The IANA time zone folk have deprecated use of a "posixrules" file in
the tz database.  While for now it's our choice whether to keep
supplying one in our own builds, installations built with
--with-system-tzdata will soon be needing to cope with that file not
being present, at least on some platforms.

This causes a problem for the horology test, which expected the
nonstandard POSIX zone spec "CST7CDT" to apply pre-2007 US daylight
savings rules.  That does happen if the posixrules file supplies such
information, but otherwise the test produces undesired results.
To fix, add an explicit transition date rule that matches 2005 practice.
(We could alternatively have switched the test to use some real time
zone, but it seems useful to have coverage of this type of zone spec.)

While at it, update a documentation example that also relied on
"CST7CDT"; use a real-world zone name instead.  Also, document why
the zone names EST5EDT, CST6CDT, MST7MDT, PST8PDT aren't subject to
similar failures when "posixrules" is missing.

Back-patch to all supported branches, since the hazard is the same
for all.

Discussion: https://postgr.es/m/1665379.1592581287@sss.pgh.pa.us

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9496908d465efc6116eff78dd46fda27603515d1

Modified Files
--------------
doc/src/sgml/datetime.sgml             | 12 ++++++++++++
doc/src/sgml/func.sgml                 | 22 +++++++++++++---------
src/test/regress/expected/horology.out |  3 ++-
src/test/regress/sql/horology.sql      |  3 ++-
4 files changed, 29 insertions(+), 11 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Adjust some glossary terms
Следующее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Ensure write failure reports no-disk-space