Fix buffile.c error handling.
Convert buffile.c error handling to use ereport. This fixes cases where
I/O errors were indistinguishable from EOF or not reported. Also remove
"%m" from error messages where errno would be bogus. While we're
modifying those strings, add block numbers and short read byte counts
where appropriate.
Back-patch to all supported releases.
Reported-by: Amit Khandekar <amitdkhan.pg@gmail.com>
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Alvaro Herrera <alvherre@2ndquadrant.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CA%2BhUKGJE04G%3D8TLK0DLypT_27D9dR8F1RQgNp0jK6qR0tZGWOw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7897e3bb902c557412645b82120f4d95f7474906
Modified Files
--------------
src/backend/access/gist/gistbuildbuffers.c | 24 +++++--------
src/backend/executor/nodeHashjoin.c | 24 +++++--------
src/backend/replication/backup_manifest.c | 9 ++---
src/backend/storage/file/buffile.c | 45 ++++++++++++------------
src/backend/utils/sort/logtape.c | 19 ++++++----
src/backend/utils/sort/sharedtuplestore.c | 21 +++++------
src/backend/utils/sort/tuplestore.c | 56 +++++++++++++-----------------
7 files changed, 88 insertions(+), 110 deletions(-)