pgsql: Fix partitioned index creation with foreign partitions
От | Alvaro Herrera |
---|---|
Тема | pgsql: Fix partitioned index creation with foreign partitions |
Дата | |
Msg-id | E1hgGZr-00036R-BH@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix partitioned index creation with foreign partitions When a partitioned tables contains foreign tables as partitions, it is not possible to implement unique or primary key indexes -- but when regular indexes are created, there is no reason to do anything other than ignoring such partitions. We were raising errors upon encountering the foreign partitions, which is unfriendly and doesn't protect against any actual problems. Relax this restriction so that index creation is allowed on partitioned tables containing foreign partitions, becoming a no-op on them. (We may later want to redefine this so that the FDW is told to create the indexes on the foreign side.) This applies to CREATE INDEX, as well as ALTER TABLE / ATTACH PARTITION and CREATE TABLE / PARTITION OF. Backpatch to 11, where indexes on partitioned tables were introduced. Discussion: https://postgr.es/m/15724-d5a58fa9472eef4f@postgresql.org Author: Álvaro Herrera Reviewed-by: Amit Langote Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9653ca2197e241ebeae127086ce1cc8b201a477e Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 2 +- doc/src/sgml/ref/create_foreign_table.sgml | 4 +-- src/backend/commands/indexcmds.c | 20 +++++++++++ src/backend/commands/tablecmds.c | 45 ++++++++++++++++++++++++ src/backend/tcop/utility.c | 12 +++++-- src/test/regress/expected/foreign_data.out | 56 ++++++++++++++++++++++++++++-- src/test/regress/sql/foreign_data.sql | 42 +++++++++++++++++++++- 7 files changed, 172 insertions(+), 9 deletions(-)
В списке pgsql-committers по дате отправления: