pgsql: Fix more strcmp() calls using boolean-like comparisons forresul

Fix more strcmp() calls using boolean-like comparisons for result checks

Such calls can confuse the reader as strcmp() uses an integer as result.
The places patched here have been spotted by Thomas Munro, David Rowley
and myself.

Author: Michael Paquier
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/20190411021946.GG2728@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d527fda6216780281b90f48820ae978c61c7905c

Modified Files
--------------
contrib/spi/refint.c                             | 9 ++++++---
src/backend/commands/lockcmds.c                  | 3 ++-
src/backend/tsearch/spell.c                      | 8 ++++----
src/test/modules/test_rls_hooks/test_rls_hooks.c | 8 ++++----
4 files changed, 16 insertions(+), 12 deletions(-)