pgsql: Fix bogus logic for skipping unnecessary partcollationdependenc

Fix bogus logic for skipping unnecessary partcollation dependencies.

The idea here is to not call recordDependencyOn for the default collation,
since we know that's pinned.  But what the code actually did was to record
the partition key's dependency on the opclass twice, instead.

Evidently introduced by sloppy coding in commit 2186b608b.  Back-patch
to v10 where that came in.

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8b90174e3f0638ff542bef7f367429750d18b08c

Modified Files
--------------
src/backend/catalog/heap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)