pgsql: InsertPgAttributeTuple() to set attcacheoff

InsertPgAttributeTuple() to set attcacheoff

InsertPgAttributeTuple() is the interface between in-memory tuple
descriptors and on-disk pg_attribute, so it makes sense to give it the
job of resetting attcacheoff.  This avoids having all the callers having
to do so.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e4597ee65d683e11a57a4b7f597807ebf44b6cf1

Modified Files
--------------
src/backend/catalog/heap.c       | 9 ++++-----
src/backend/catalog/index.c      | 5 -----
src/backend/commands/tablecmds.c | 1 -
3 files changed, 4 insertions(+), 11 deletions(-)