libpq: PQhost to return active connected host or hostaddr
Previously, PQhost didn't return the connected host details when the
connection type was CHT_HOST_ADDRESS (i.e., via hostaddr). Instead, it
returned the complete host connection parameter (which could contain
multiple hosts) or the default host details, which was confusing and
arguably incorrect.
Change this to return the actually connected host or hostaddr
irrespective of the connection type. When hostaddr but no host was
specified, hostaddr is now returned. Never return the original host
connection parameter, and document that PQhost cannot be relied on
before the connection is established.
PQport is similarly changed to always return the active connection port
and never the original connection parameter.
Back-patch of commit 1944cdc98273dbb8439ad9b387ca2858531afcf0
into the v10 branch.
Author: Hari Babu <kommi.haribabu@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Reviewed-by: David G. Johnston <david.g.johnston@gmail.com>
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/62038810b73dbb78c66c28a24642b0e066e0b1a1
Modified Files
--------------
doc/src/sgml/libpq.sgml | 48 +++++++++++++++++++++++++++++++++++++--
src/interfaces/libpq/fe-connect.c | 25 ++++++++++----------
2 files changed, 59 insertions(+), 14 deletions(-)