pgsql: Enable failure to rename a partitioned index

Enable failure to rename a partitioned index

Concurrently with partitioned index development (commit 8b08f7d4820f),
the code to handle failure to rename indexes was refactored (commit
8b9e9644dc6a).  Turns out that that particular case was untested, which
naturally led it to be broken.  Add tests and the missing code line.

Co-authored-by: David Rowley <dgrowley@gmail.com>
Co-authored-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reported-by: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>
Discussion: https://postgr.es/m/CAKcux6mfYMS3OX0ywjOiWiGSEKhJf-1zdeTceHFbd0mScUzU5A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/040da42367a5de448ddecf6ee7c09f73580a6b28

Modified Files
--------------
src/backend/catalog/objectaddress.c          |  1 +
src/test/regress/expected/alter_table.out    | 18 ++++++++++++++++++
src/test/regress/expected/object_address.out | 11 +++++++++--
src/test/regress/sql/alter_table.sql         | 15 +++++++++++++++
src/test/regress/sql/object_address.sql      |  5 +++++
5 files changed, 48 insertions(+), 2 deletions(-)