[COMMITTERS] pgsql: Remove broken and useless entry-count printing in HASH_DEBUGcod

Поиск
Список
Период
Сортировка
От Tom Lane
Тема [COMMITTERS] pgsql: Remove broken and useless entry-count printing in HASH_DEBUGcod
Дата
Msg-id E1dcwKg-0001KU-L8@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Remove broken and useless entry-count printing in HASH_DEBUG code.

init_htab(), with #define HASH_DEBUG, prints a bunch of hashtable
parameters.  It used to also print nentries, but commit 44ca4022f changed
that to "hash_get_num_entries(hctl)", which is wrong (the parameter should
be "hashp").

Rather than correct the coding, though, let's just remove that field from
the printout.  The table must be empty, since we just finished building
it, so expensively calculating the number of entries is rather pointless.
Moreover hash_get_num_entries makes assumptions (about not needing locks)
which we could do without in debugging code.

Noted by Choi Doo-Won in bug #14764.  Back-patch to 9.6 where the
faulty code was introduced.

Discussion: https://postgr.es/m/20170802032353.8424.12274@wrigleys.postgresql.org

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cf9da98600f1874d2046bfbc9439ff311370d7db

Modified Files
--------------
src/backend/utils/hash/dynahash.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: [COMMITTERS] pgsql: Get a snapshot before COPY in table sync
Следующее
От: Tom Lane
Дата:
Сообщение: [COMMITTERS] pgsql: Silence warning from modern perl about unescaped braces