[COMMITTERS] pgsql: brin: Don't crash on auto-summarization

brin: Don't crash on auto-summarization

We were trying to free a pointer into a shared buffer, which never
works; and we were failing to release the buffer lock appropriately.
Fix those omissions.

While at it, improve documentation for brinGetTupleForHeapBlock, the
inadequacy of which evidently caused these bugs in the first place.

Reported independently by Zhou Digoal (bug #14668) and Alexander Sosna.

Discussion: https://postgr.es/m/8c31c11b-6adb-228d-22c2-4ace89fc9209@credativ.de
Discussion: https://postgr.es/m/20170524063323.29941.46339@wrigleys.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b4da9d0e1ee45a1d157dc7fd24b24745b16ebe9f

Modified Files
--------------
src/backend/access/brin/brin.c        |  3 ++-
src/backend/access/brin/brin_revmap.c | 13 ++++++++-----
2 files changed, 10 insertions(+), 6 deletions(-)