[COMMITTERS] pgsql: Remove useless duplicate inclusions of system header files.
От | Tom Lane |
---|---|
Тема | [COMMITTERS] pgsql: Remove useless duplicate inclusions of system header files. |
Дата | |
Msg-id | E1chjeP-0006Nh-V1@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Remove useless duplicate inclusions of system header files. c.h #includes a number of core libc header files, such as <stdio.h>. There's no point in re-including these after having read postgres.h, postgres_fe.h, or c.h; so remove code that did so. While at it, also fix some places that were ignoring our standard pattern of "include postgres[_fe].h, then system header files, then other Postgres header files". While there's not any great magic in doing it that way rather than system headers last, it's silly to have just a few files deviating from the general pattern. (But I didn't attempt to enforce this globally, only in files I was touching anyway.) I'd be the first to say that this is mostly compulsive neatnik-ism, but over time it might save enough compile cycles to be useful. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/9e3755ecb2d058f7d123dd35a2e1784006190962 Modified Files -------------- contrib/fuzzystrmatch/dmetaphone.c | 12 +++++++----- contrib/ltree/crc32.c | 4 ---- contrib/pgcrypto/px.h | 1 - src/backend/access/transam/timeline.c | 1 - src/backend/access/transam/twophase.c | 1 - src/backend/access/transam/xlogarchive.c | 1 - src/backend/commands/dbcommands.c | 1 - src/backend/commands/tablespace.c | 1 - src/backend/libpq/ifaddr.c | 1 - src/backend/port/atomics.c | 1 - src/backend/port/dynloader/freebsd.h | 1 - src/backend/port/dynloader/netbsd.h | 1 - src/backend/port/dynloader/openbsd.h | 1 - src/backend/port/win32/crashdump.c | 3 +-- src/backend/postmaster/autovacuum.c | 1 - src/backend/replication/basebackup.c | 1 - src/backend/replication/logical/snapbuild.c | 1 - src/backend/replication/walreceiverfuncs.c | 1 - src/backend/storage/ipc/dsm.c | 1 - src/backend/storage/ipc/dsm_impl.c | 1 - src/backend/storage/ipc/latch.c | 1 - src/backend/utils/adt/cash.c | 1 - src/backend/utils/adt/dbsize.c | 1 - src/backend/utils/adt/inet_cidr_ntop.c | 1 - src/backend/utils/adt/inet_net_pton.c | 1 - src/backend/utils/adt/pg_locale.c | 1 - src/backend/utils/init/miscinit.c | 1 - src/bin/initdb/initdb.c | 1 - src/bin/pg_basebackup/pg_basebackup.c | 1 - src/bin/pg_basebackup/pg_receivewal.c | 1 - src/bin/pg_basebackup/streamutil.c | 3 --- src/bin/pg_ctl/pg_ctl.c | 11 ++++------- src/bin/pg_dump/parallel.c | 14 ++++++-------- src/bin/pg_dump/pg_backup_archiver.c | 16 +++++++--------- src/bin/pg_dump/pg_dump.c | 3 --- src/bin/pg_dump/pg_dumpall.c | 4 ---- src/bin/pg_dump/pg_restore.c | 15 +++++---------- src/bin/pg_resetwal/pg_resetwal.c | 1 - src/bin/pg_rewind/copy_fetch.c | 2 -- src/bin/pg_rewind/fetch.c | 1 - src/bin/pg_rewind/file_ops.c | 1 - src/bin/pg_rewind/filemap.c | 1 - src/bin/pg_rewind/libpq_fetch.c | 1 - src/bin/pg_upgrade/dump.c | 1 - src/bin/pg_upgrade/exec.c | 5 ++--- src/bin/pg_upgrade/option.c | 11 +++++------ src/bin/pg_upgrade/parallel.c | 9 +++------ src/bin/pg_upgrade/tablespace.c | 2 -- src/bin/pgevent/pgevent.c | 6 ------ src/bin/psql/command.c | 2 -- src/bin/psql/crosstabview.c | 2 -- src/bin/psql/help.c | 1 - src/bin/psql/startup.c | 4 ---- src/common/ip.c | 1 - src/common/username.c | 2 -- src/common/wait_error.c | 2 -- src/fe_utils/print.c | 1 - src/include/libpq/libpq.h | 1 - src/include/port/atomics/generic-msvc.h | 1 - src/include/utils/pg_locale.h | 1 - src/interfaces/ecpg/ecpglib/data.c | 2 -- src/interfaces/ecpg/ecpglib/execute.c | 1 - src/interfaces/ecpg/ecpglib/typename.c | 1 - src/interfaces/ecpg/preproc/ecpg.c | 2 +- src/interfaces/ecpg/preproc/pgc.l | 1 - src/interfaces/libpq/fe-connect.c | 1 - src/interfaces/libpq/libpq-int.h | 1 - src/interfaces/libpq/pthread-win32.c | 1 - src/pl/plperl/plperl.c | 1 - src/port/chklocale.c | 5 ----- src/port/dirmod.c | 1 - src/port/inet_net_ntop.c | 1 - src/port/open.c | 1 - src/port/system.c | 1 - src/test/isolation/isolationtester.c | 3 --- src/timezone/strftime.c | 1 - src/timezone/zic.c | 1 - 77 files changed, 41 insertions(+), 155 deletions(-)
В списке pgsql-committers по дате отправления:
Предыдущее
От: Bruce MomjianДата:
Сообщение: [COMMITTERS] pgsql: Add /config.cache to .gitignore in back branches
Следующее
От: Tom LaneДата:
Сообщение: [COMMITTERS] pgsql: Remove some configure header-file checks that we weren'treally