Avoid testing tuple visibility without buffer lock in RI_FKey_check().
Despite the argumentation I wrote in commit 7a2fe85b0, it's unsafe to do
this, because in corner cases it's possible for HeapTupleSatisfiesSelf
to try to set hint bits on the target tuple; and at least since 8.2 we
have required the buffer content lock to be held while setting hint bits.
The added regression test exercises one such corner case. Unpatched, it
causes an assertion failure in assert-enabled builds, or otherwise would
cause a hint bit change in a buffer we don't hold lock on, which given
the right race condition could result in checksum failures or other data
consistency problems. The odds of a problem in the field are probably
pretty small, but nonetheless back-patch to all supported branches.
Report: <19391.1477244876@sss.pgh.pa.us>
Branch
------
REL9_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/676c603755090c94f0072d435c54f440fda6b9d4
Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 22 ++++++++++------------
src/test/regress/expected/foreign_key.out | 21 +++++++++++++++++++++
src/test/regress/sql/foreign_key.sql | 23 +++++++++++++++++++++++
3 files changed, 54 insertions(+), 12 deletions(-)