pgsql: Adjust datatype of ReplicationState.acquired_by.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Adjust datatype of ReplicationState.acquired_by.
Дата
Msg-id E1aqjyF-0004Yk-NV@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Adjust datatype of ReplicationState.acquired_by.

It was declared as "pid_t", which would be fine except that none of
the places that printed it in error messages took any thought for the
possibility that it's not equivalent to "int".  This leads to warnings
on some buildfarm members, and could possibly lead to actually wrong
error messages on those platforms.  There doesn't seem to be any very
good reason not to just make it "int"; it's only ever assigned from
MyProcPid, which is int.  If we want to cope with PIDs that are wider
than int, this is not the place to start.

Also, fix the comment, which seems to perhaps be a leftover from a time
when the field was only a bool?

Per buildfarm.  Back-patch to 9.5 which has same issue.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/994f11257328e272a6a43d3de59ffa916cbfbe96

Modified Files
--------------
src/backend/replication/logical/origin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Adjust datatype of ReplicationState.acquired_by.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Adjust signature of walrcv_receive hook.