pgsql: Code review/prettification for generic_xlog.c.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Code review/prettification for generic_xlog.c.
Дата
Msg-id E1aoy9X-0002xZ-TA@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Code review/prettification for generic_xlog.c.

Improve commentary, use more specific names for the delta fields,
const-ify pointer arguments where possible, avoid assuming that
initializing only the first element of a local array will guarantee
that the remaining elements end up as we need them.  (I think that
code in generic_redo actually worked, but only because InvalidBuffer
is zero; this is a particularly ugly way of depending on that ...)

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/db03cf375d602e417eda6b7a55eead91618e1398

Modified Files
--------------
src/backend/access/transam/generic_xlog.c | 159 +++++++++++++++++-------------
1 file changed, 92 insertions(+), 67 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Run pgindent on generic_xlog.c.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Get rid of blinsert()'s use of GenericXLogUnregister().