pgsql: Suppress compiler warnings about useless comparison of unsigned

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Suppress compiler warnings about useless comparison of unsigned
Дата
Msg-id E1aVRNZ-00054U-0p@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Suppress compiler warnings about useless comparison of unsigned to zero.

Reportedly, some compilers warn about tests like "c < 0" if c is unsigned,
and hence complain about the character range checks I added in commit
3bb3f42f3749d40b8d4de65871e8d828b18d4a45.  This is a bit of a pain since
the regex library doesn't really want to assume that chr is unsigned.
However, since any such reconfiguration would involve manual edits of
regcustom.h anyway, we can put it on the shoulders of whoever wants to
do that to adjust this new range-checking macro correctly.

Per gripes from Coverity and Andres.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e781baa6408e6f43ad71d4546cc47cb348b3104e

Modified Files
--------------
src/backend/regex/regc_lex.c  |  6 +++---
src/include/regex/regcustom.h | 11 +++++++++++
2 files changed, 14 insertions(+), 3 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Suppress compiler warnings about useless comparison of unsigned
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Suppress compiler warnings about useless comparison of unsigned