Fix broken assertion in BRIN code
The code was assuming that any NULL value in scan keys was due to IS
NULL or IS NOT NULL, but it turns out to be possible to get them with
other operators too, if they are used in contrived-enough ways. Easiest
way out of the problem seems to check explicitely for the IS NOT NULL
flag, instead of assuming it must be set if the IS NULL flag is not set,
when a null scan key is found; if neither flag is set, follow the lead
of other index AMs and assume that all indexable operators must be
strict, and thus the query is never satisfiable.
Also, add a comment to try and lure some future hacker into improving
analysis of scan keys in brin.
Per report from Andreas Seltenreich; diagnosis by Tom Lane.
Backpatch to 9.5.
Discussion: http://www.postgresql.org/message-id/20646.1437919632@sss.pgh.pa.us
Branch
------
REL9_5_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/244c378e243e3649efc99fe96ec9f123bbe9ffbc
Modified Files
--------------
src/backend/access/brin/brin.c | 8 ++++++++
src/backend/access/brin/brin_inclusion.c | 10 ++++++++--
src/backend/access/brin/brin_minmax.c | 10 ++++++++--
3 files changed, 24 insertions(+), 4 deletions(-)