pgsql: Fix ON CONFLICT bugs that manifest when used in rules.

Поиск
Список
Период
Сортировка
От Andres Freund
Тема pgsql: Fix ON CONFLICT bugs that manifest when used in rules.
Дата
Msg-id E1YsIRm-0008Ol-6u@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix ON CONFLICT bugs that manifest when used in rules.

Specifically the tlist and rti of the pseudo "excluded" relation weren't
properly treated by expression_tree_walker, which lead to errors when
excluded was referenced inside a rule because the varnos where not
properly adjusted.  Similar omissions in OffsetVarNodes and
expression_tree_mutator had less impact, but should obviously be fixed
nonetheless.

A couple tests of for ON CONFLICT UPDATE into INSERT rule bearing
relations have been added.

In passing I updated a couple comments.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4af6e61a363246cf7fff3368a76603b0ce9945dd

Modified Files
--------------
src/backend/executor/nodeModifyTable.c |    1 +
src/backend/nodes/nodeFuncs.c          |    3 +
src/backend/optimizer/plan/setrefs.c   |    9 ++-
src/backend/rewrite/rewriteManip.c     |   15 ++++-
src/test/regress/expected/rules.out    |  105 +++++++++++++++++++++++++++++---
src/test/regress/sql/rules.sql         |   35 ++++++++++-
6 files changed, 151 insertions(+), 17 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: Allow on-the-fly capture of DDL event details
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: PL/Python: Remove procedure cache invalidation