Fix multiple bugs and infelicities in pg_rewind.
Bugs all spotted by Coverity, including wrong realloc() size request
and memory leaks. Cosmetic improvements by me.
The usage of the global variable "filemap" here is still pretty awful,
but at least I got rid of the gratuitous aliasing in several routines
(which was helping to annoy Coverity, as well as being a bug risk).
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/c67f366fa9f748257861ee233b47b80eb5ffa857
Modified Files
--------------
src/bin/pg_rewind/filemap.c | 60 +++++++++++++++++++++------------------
src/bin/pg_rewind/filemap.h | 24 ++++++----------
src/bin/pg_rewind/libpq_fetch.c | 4 +++
src/bin/pg_rewind/pg_rewind.c | 2 +-
4 files changed, 46 insertions(+), 44 deletions(-)