pgsql: Fix minor memory leak in ident_inet().

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Fix minor memory leak in ident_inet().
Дата
Msg-id E1YLhM6-0002H1-RT@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix minor memory leak in ident_inet().

We'd leak the ident_serv data structure if the second pg_getaddrinfo_all
(the one for the local address) failed.  This is not of great consequence
because a failure return here just leads directly to backend exit(), but
if this function is going to try to clean up after itself at all, it should
not have such holes in the logic.  Try to fix it in a future-proof way by
having all the failure exits go through the same cleanup path, rather than
"optimizing" some of them.

Per Coverity.  Back-patch to 9.2, which is as far back as this patch
applies cleanly.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/58146d35deed3bd3e05ce4b5ba529e4e4a369ddb

Modified Files
--------------
src/backend/libpq/auth.c |   21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix more memory leaks in failure path in buildACLCommands.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix minor memory leak in ident_inet().