Move pg_crc.c to src/common, and remove pg_crc_tables.h
To get CRC functionality in a client program, you now need to link with
libpgcommon instead of libpgport. The CRC code has nothing to do with
portability, so libpgcommon is a better home. (libpgcommon didn't exist
when pg_crc.c was originally moved to src/port.)
Remove the possibility to get CRC functionality by just #including
pg_crc_tables.h. I'm not aware of any extensions that actually did that and
couldn't simply link with libpgcommon.
This also moves the pg_crc.h header file from src/include/utils to
src/include/common, which will require changes to any external programs
that currently does #include "utils/pg_crc.h". That seems acceptable, as
include/common is clearly the right home for it now, and the change needed
to any such programs is trivial.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/c619c2351f7ec429b6ddce519c939f7b8465d711
Modified Files
--------------
contrib/hstore/hstore_gist.c | 2 +-
contrib/ltree/crc32.c | 2 +-
src/backend/utils/adt/tsquery.c | 1 +
src/common/Makefile | 2 +-
src/common/pg_crc.c | 166 +++++++++++++++++++++++++++++++++++
src/include/access/xlogrecord.h | 2 +-
src/include/catalog/pg_control.h | 2 +-
src/include/common/pg_crc.h | 121 ++++++++++++++++++++++++++
src/include/tsearch/ts_type.h | 1 -
src/include/utils/pg_crc.h | 121 --------------------------
src/include/utils/pg_crc_tables.h | 171 -------------------------------------
src/port/Makefile | 2 +-
src/port/pg_crc.c | 21 -----
13 files changed, 294 insertions(+), 320 deletions(-)