Fix query-duration memory leak with GIN rescans.
The requiredEntries / additionalEntries arrays were not freed in
freeScanKeys() like other per-key stuff.
It's not obvious, but startScanKey() was only ever called after the keys
have been initialized with ginNewScanKey(). That's why it doesn't need to
worry about freeing existing arrays. The ginIsNewKey() test in gingetbitmap
was never true, because ginrescan free's the existing keys, and it's not OK
to call gingetbitmap twice in a row without calling ginrescan in between.
To make that clear, remove the unnecessary ginIsNewKey(). And just to be
extra sure that nothing funny happens if there is an existing key after all,
call freeScanKeys() to free it if it exists. This makes the code more
straightforward.
(I'm seeing other similar leaks in testing a query that rescans an GIN index
scan, but that's a different issue. This just fixes the obvious leak with
those two arrays.)
Backpatch to 9.4, where GIN fast scan was added.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/68fa75f3188c050ec62804f2bfacd3ea85404743
Modified Files
--------------
src/backend/access/gin/ginget.c | 10 +++++++---
src/backend/access/gin/ginscan.c | 16 ++++++++++++----
src/include/access/gin_private.h | 1 +
3 files changed, 20 insertions(+), 7 deletions(-)