pgsql: Fix volatile-safety issue in dblink's materializeQueryResult().

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Fix volatile-safety issue in dblink's materializeQueryResult().
Дата
Msg-id E1YFq6f-0000t9-Ex@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix volatile-safety issue in dblink's materializeQueryResult().

Some fields of the sinfo struct are modified within PG_TRY and then
referenced within PG_CATCH, so as with recent patch to async.c, "volatile"
is necessary for strict POSIX compliance; and that propagates to a couple
of subroutines as well as materializeQueryResult() itself.  I think the
risk of actual issues here is probably higher than in async.c, because
storeQueryResult() is likely to get inlined into materializeQueryResult(),
leaving the compiler free to conclude that its stores into sinfo fields are
dead code.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e4021a2ba647e61340b096d49b1a657eeafdc617

Modified Files
--------------
contrib/dblink/dblink.c |   12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix volatile-safety issue in dblink's materializeQueryResult().
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Add a note to PG_TRY's documentation about volatile safety.