pgsql: Fix some jsonb issues found by Coverity in recent commits.

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема pgsql: Fix some jsonb issues found by Coverity in recent commits.
Дата
Msg-id E1Y0uFv-0003wh-PI@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix some jsonb issues found by Coverity in recent commits.

Mostly these issues concern the non-use of function results. These
have been changed to use (void) pushJsonbValue(...) instead of assigning
the result to a variable that gets overwritten before it is used.

There is a larger issue that we should possibly examine the API for
pushJsonbValue(), so that instead of returning a value it modifies a
state argument. The current idiom is rather clumsy. However, changing
that requires quite a bit more work, so this change should do for the
moment.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c8315930e6a34b616d9840985c85eb0d856dd2df

Modified Files
--------------
src/backend/utils/adt/jsonb.c     |   16 ++++++++--------
src/backend/utils/adt/jsonfuncs.c |    4 +++-
2 files changed, 11 insertions(+), 9 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: pgsql: Misc comment typo fixes.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix file descriptor leak after failure of a \setshell command in