pgAdmin III commit: Improve the handling of the dirty flag in the query

Поиск
Список
Период
Сортировка
От Dave Page
Тема pgAdmin III commit: Improve the handling of the dirty flag in the query
Дата
Msg-id E1WqKMp-0007dQ-BR@gothos.postgresql.org
обсуждение исходный текст
Список pgadmin-hackers
Improve the handling of the dirty flag in the query tool:

Attached patch adds member variable to track last origin of query
modification:
    ORIGIN_MANUAL - edited directly by user
    ORIGIN_FILE - loaded from file
    ORIGIN_INITIAL - passed into constructor
    ORIGIN_HISTORY - picked from "previous queries"
    ORIGIN_GQB - generated by query builder

Such approach allows for some enhancements of user's experience.
I've implemented the following in this patch:

1. Text initialization in constructor isn't considered a change, so it
will not ask for save confirmation if left intact.

2. Allow to "Save As" the initial text immediately, without having to
modify text in order to enable save button. Also the behaviour
shouldn't depend on settings->GetStickySql(), because there are other
use-cases not related to this option (for example, insert-scripts on a
table).

3. Skip confirmation to replace query text by GQB if previously it was
generated by GQB and was left intact.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e3672540de81dddeed2a8ae54de36e3884a06e9b
Author: J.F. Oster <jinfroster@mail.ru>

Modified Files
--------------
pgadmin/frm/frmQuery.cpp       |   64 +++++++++++++++++++++++++++++-----------
pgadmin/include/frm/frmQuery.h |   16 ++++++++++
2 files changed, 62 insertions(+), 18 deletions(-)


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Fix for a problem with auto reconnection
Следующее
От: Dave Page
Дата:
Сообщение: Re: PATCH: Precise control over query's modification state