pgsql: Further pg_dump / ftello improvements

Further pg_dump / ftello improvements

Make ftello error-checking consistent to all calls and remove a
bit of ftello-related code which has been #if 0'd out since 2001.

Note that we are not concerned with the ftello() call under
snprintf() failing as it is just building a string to call
exit_horribly() with; printing -1 in such a case is fine.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/dfb1e9bdc0d0a506899b11038c7fce9631cac9fe

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c |    3 +--
src/bin/pg_dump/pg_backup_tar.c      |   17 +++--------------
2 files changed, 4 insertions(+), 16 deletions(-)