Clear MyProc and MyProcSignalState before they become invalid.
Evidence from buildfarm member crake suggests that the new test_shm_mq
module is routinely crashing the server due to the arrival of a SIGUSR1
after the shared memory segment has been unmapped. Although processes
using the new dynamic background worker facilities are more likely to
receive a SIGUSR1 around this time, the problem is also possible on older
branches, so I'm back-patching the parts of this change that apply to
older branches as far as they apply.
It's already generally the case that code checks whether these pointers
are NULL before deferencing them, so the important thing is mostly to
make sure that they do get set to NULL before they become invalid. But
in master, there's one case in procsignal_sigusr1_handler that lacks a
NULL guard, so add that.
Patch by me; review by Tom Lane.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d1981719adbcc05fa15f540e8fc4327907991fc6
Modified Files
--------------
src/backend/storage/ipc/procsignal.c | 9 +++++++-
src/backend/storage/lmgr/proc.c | 42 ++++++++++++++++++++--------------
2 files changed, 33 insertions(+), 18 deletions(-)