pgsql: Be sure to close() file descriptor on error case

Поиск
Список
Период
Сортировка
От Stephen Frost
Тема pgsql: Be sure to close() file descriptor on error case
Дата
Msg-id E1UyTsy-0000Ha-R5@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Be sure to close() file descriptor on error case

In receivelog.c:writeTimeLineHistoryFile(), we were not properly
closing the open'd file descriptor in error cases.  While this
wouldn't matter much if we were about to exit due to such an
error, that's not the case with pg_receivexlog as it can be a
long-running process and these errors are non-fatal.

This resource leak was found by the Coverity scanner.

Back-patch to 9.3 where this issue first appeared.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/b68a1fc7ff1a50a7282e8edff7c51333274c3334

Modified Files
--------------
src/bin/pg_basebackup/receivelog.c |    2 ++
1 file changed, 2 insertions(+)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: pgsql: Be sure to close() file descriptor on error case
Следующее
От: Stephen Frost
Дата:
Сообщение: pgsql: Fix resource leak in initdb -X option