pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate

Fill tuple before HeapSatisfiesHOTAndKeyUpdate

Failing to do this results in almost all updates to system catalogs
being non-HOT updates, because the OID column would differ (not having
been set for the new tuple), which is an indexed column.

While at it, make sure to set the tableoid early in both old and new
tuples as well.  This isn't of much consequence, since that column is
seldom (never?) indexed.

Report and patch from Andres Freund.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9ee00ef4c7de991b9371f614ce9c03ff436ce383

Modified Files
--------------
src/backend/access/heap/heapam.c |   39 +++++++++++++++++++++++--------------
1 files changed, 24 insertions(+), 15 deletions(-)