Fix ruleutils to cope with conflicts from adding/dropping/renaming columns.
In commit 11e131854f8231a21613f834c40fe9d046926387, we improved the
rule/view dumping code so that it would produce valid query representations
even if some of the tables involved in a query had been renamed since the
query was parsed. This patch extends that idea to fix problems that occur
when individual columns are renamed, or added or dropped. As before, the
core of the fix is to assign unique new aliases when a name conflict has
been created. This is complicated by the JOIN USING feature, which
requires the same column alias to be used in both input relations, but we
can handle that with a sufficiently complex approach to assigning aliases.
A fortiori, this patch takes care of situations where the query didn't have
unique column names to begin with, such as in a recent complaint from Bryan
Nuse. (Because of expansion of "SELECT *", re-parsing a dumped query can
require column name uniqueness even though the original text did not.)
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/2ffa740be9d96a3743ecb7e42391c53d0760c65a
Modified Files
--------------
src/backend/commands/explain.c | 14 +-
src/backend/commands/typecmds.c | 15 +-
src/backend/utils/adt/ruleutils.c | 1452 +++++++++++++++++++++++++----
src/test/regress/expected/create_view.out | 428 ++++++++--
src/test/regress/sql/create_view.sql | 109 +++-
5 files changed, 1764 insertions(+), 254 deletions(-)